[Webkit-unassigned] [Bug 68295] Remove preserves3D() from CCLayerDelegate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68295





--- Comment #8 from Antoine Labour <piman at chromium.org>  2011-09-23 15:54:08 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=108436&action=review

>> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:367
>> +        platformLayer->setPreserves3D(m_preserves3D);
> 
> I don't think we need to do this - the canvas contents layer can't have preserves3D set since it's a CSS property and would only apply to the container layer, and even if it could we should be able to rely on the normal property propagation code

Done.

>> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:400
>> +        layer->setPreserves3D(m_preserves3D);
> 
> same here - i don't think media layers can have this bit

Done.

>> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:600
>> +        m_contentsLayer->setPreserves3D(m_preserves3D);
> 
> it looks like we used to propagate the preserves3D bit to the contents layer.  this change preserves that behavior but I think it's actually wrong. Can you see if any tests break if you only propagate the preserves3D bit to the m_layer?

Done. Layout tests still pass.

>> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:652
>> +        m_contentsLayer->setPreserves3D(m_preserves3D);
> 
> do we need this?

Removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.