[Webkit-unassigned] [Bug 63502] [EFL] Move GtkWidgetBackingStoreCairo to the cairo directory and modify to use in the EFL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63502


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108437|                            |review-
               Flag|                            |




--- Comment #36 from Martin Robinson <mrobinson at webkit.org>  2011-09-23 06:35:13 PST ---
(From update of attachment 108437)
View in context: https://bugs.webkit.org/attachment.cgi?id=108437&action=review

Much nicer, but please fix the minor stuff below. :)

> Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp:23
> +#if (PLATFORM(GTK) && !defined(XP_UNIX)) || PLATFORM(EFL)

You shouldn't need this line. If a platform doesn't want to compile this file, they just won't have it on their source list.

> Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp:45
> +#elif PLATFORM(EFL)
> +    return adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32, size.width(), size.height()));
> +#else
> +    return nullptr;
> +#endif

It would be better to simply have

#if PLATFORM(GTK)
...
#else
    return adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32, size.width(), size.height()));
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.