[Webkit-unassigned] [Bug 68235] [GTK][WK2] Initial implementation of WebInspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 23 05:55:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68235





--- Comment #34 from Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com>  2011-09-23 05:55:36 PST ---
(In reply to comment #32)
> (From update of attachment 108375 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108375&action=review
> 
> > Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:116
> > +    GOwnPtr<gchar> filePath(g_build_filename("file://", DATA_DIR, "webkitgtk-", WEBKITGTK_API_VERSION_STRING, "webinspector", "inspector.html", NULL));
> 
> You are still creating this path at runtime when I asked if you would make it a static string contructed at build time.
Sorry missed out in last patch. Done in latest patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list