[Webkit-unassigned] [Bug 68513] <input> with autofocus doesn't lose focus when it has a certain onblur listener

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68513


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108453|review?                     |review-
               Flag|                            |




--- Comment #14 from Kent Tamura <tkent at chromium.org>  2011-09-23 03:10:59 PST ---
(From update of attachment 108453)
View in context: https://bugs.webkit.org/attachment.cgi?id=108453&action=review

r- because of test style.

> LayoutTests/fast/forms/autofocus-focus-only-once.html:6
> + input { background:red }
> + input:focus { background:lime }

One-space indentation looks strange.
Please remove the indentation.

> LayoutTests/fast/forms/autofocus-focus-only-once.html:12
> +<script language="JavaScript" type="text/javascript">
> +    function log(message) {
> +        document.getElementById("console").innerHTML += "<li>"+message+"</li>";
> +    }
> +

Indenting the all of the content by four spaces is meaningless.  Please remove the indentation.

> LayoutTests/fast/forms/autofocus-focus-only-once.html:30
> +        if (document.activeElement == document.getElementById("input2"))
> +            log("SUCCESS");
> +        else
> +            log("FAILURE");

You had better load LayoutTests/fast/js/resource/js-test-pre.js, and write shouldBe('document.activeElement', 'document.getElementById("input2")').
See LayoutTests/fast/forms/autofocus-keygen.html, etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.