[Webkit-unassigned] [Bug 68592] wrap attribute of textarea element cannot be accessed by JavaScript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68592


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108332|review?                     |review-
               Flag|                            |




--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-09-23 03:03:34 PST ---
(From update of attachment 108332)
View in context: https://bugs.webkit.org/attachment.cgi?id=108332&action=review

> Source/WebCore/html/HTMLTextAreaElement.idl:40
> +        attribute [Reflect] DOMString wrap;

Please insert this line at the next to "row" attribute. We'd like to follow the IDL in the specification as possible.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element

Also [Reflect] is wrong in this case.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#attr-textarea-wrap
If the wrap HTML attribute is missing, we need to return "soft" for the wrap IDL attribute.

> LayoutTests/fast/forms/textarea-wrap-attribute.html:6
> +<textarea wrap="hard" cols="20"> This is a simple text-area1 </textarea> 
> +<textarea wrap="soft"> This is a simple text-area2 </textarea> 

The test coverage is too low.
- wrap HTML attribtue is missing
- wrap HTML attribute has an invalid value
- setting values to wrap IDL attribute
- ...

> LayoutTests/fast/forms/textarea-wrap-attribute.html:22
> +logResult("Text Area with hard wrap","hard", textArea.wrap);

You had better load fast/js/resources/js-test-pre.js, and write shouldBe('textArea.wrap', '"hard"');

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.