[Webkit-unassigned] [Bug 68434] [GTK] Implement cache model for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68434





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-22 23:17:37 PST ---
(In reply to comment #4)
> (From update of attachment 108325 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108325&action=review
> 
> Looks good to me. We just need another reviewer to approve the API.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:83
> > + * determine its caching behavior. All web views follow the cache
> 
> Should probably say all #WebkitWebViews in  #WebKitWebContext follow the cache model

Ok.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:85
> > + * for caching previously viewed content .
> 
> Extra space after 'content'

Ok.

> > Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:98
> > +    SoupSession* session = WebCore::ResourceHandle::defaultSession();
> > +    SoupCache* cache = reinterpret_cast<SoupCache*>(soup_session_get_feature(session, SOUP_TYPE_CACHE));
> 
> Might as well move these two down above:  if (cache)

I need the cache to get the free disk space:

uint64_t diskFreeSize = getCacheDiskFreeSize(cache);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.