[Webkit-unassigned] [Bug 68602] [GTK][SOUP]Support for using proxy from environment variable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68602





--- Comment #7 from Wajahat Siddiqui <mdwajahatali.siddiqui at motorola.com>  2011-09-22 21:56:05 PST ---
(In reply to comment #6)
> (From update of attachment 108301 [details])
> r- for now, unless we are sure libproxy doesn't do this already.

In case of Minibrowser, it does not do. It does only for GtkLauncher in 

Tools/GtkLauncher/main.c which is gauded by #ifndef WEBKIT2 ???

...
#ifndef WEBKIT2
#ifdef SOUP_TYPE_PROXY_RESOLVER_DEFAULT
    soup_session_add_feature_by_type(webkit_get_default_session(), SOUP_TYPE_PROXY_RESOLVER_DEFAULT);
#else
    const char *httpProxy = g_getenv("http_proxy");
    if (httpProxy) {
        SoupURI *proxyUri = soup_uri_new(httpProxy);
        g_object_set(webkit_get_default_session(), SOUP_SESSION_PROXY_URI, proxyUri, NULL);
        soup_uri_free(proxyUri);
    }
#endif
#endif
...

I think we need to set proxy at a common place in WebCore while calling ResourceHandle::defaultSession() instead at the app level if there are no design issues with this change ? This will be applicable for both GtkLauncher and Minibrowser

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.