[Webkit-unassigned] [Bug 63502] [EFL] Move GtkWidgetBackingStoreCairo to the cairo directory and modify to use in the EFL.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 22 20:53:11 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63502





--- Comment #31 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-09-22 20:53:10 PST ---
(In reply to comment #30)
> (In reply to comment #28)
> > > Source/WebCore/ChangeLog:17
> > > +        * platform/cairo/WidgetBackingStoreCairo.cpp: Added.
> > 
> > Shouldn't this say 'Copied from foo/bar.cpp'? Make sure you use svn cp (or the git equivalent here).
> 
> Yes, it is better to understand history of change. I will modify changelog as your comment :)

My point is that the tools you used to generate this patch (webkit-patch or prepare-ChangeLog) should have done this automatically. If they have not, I fear the commit bot will just svn rm GtkWidgetBackingStoreCairo.cpp and svn add WidgetBackingStoreCairo.cpp instead of using svn mv (I'm not sure, though).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list