[Webkit-unassigned] [Bug 63502] [EFL] Move GtkWidgetBackingStoreCairo to the cairo directory and modify to use in the EFL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63502





--- Comment #30 from EunMi Lee <eunmi15.lee at samsung.com>  2011-09-22 20:51:09 PST ---
(In reply to comment #28)
> (From update of attachment 108437 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108437&action=review
> 
> Informal r+ from my side once you answer the question below, the patch looks much better now.
> 
> My only concern is the way you created WidgetbackingStoreCairo.cpp -- did you properly copy GtkWidgetBackingStore.cpp and then changed it? Preserving history across renames is very important.
> 
> > Source/WebCore/ChangeLog:17
> > +        * platform/cairo/WidgetBackingStoreCairo.cpp: Added.
> 
> Shouldn't this say 'Copied from foo/bar.cpp'? Make sure you use svn cp (or the git equivalent here).

Yes, it is better to understand history of change. I will modify changelog as your comment :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.