[Webkit-unassigned] [Bug 68572] Create unit tests for LayerChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68572





--- Comment #6 from John Bates <jbates at google.com>  2011-09-22 16:55:39 PST ---
> > Source/WebKit/chromium/tests/LayerChromiumTest.cpp:188
> > +    EXPECT_EQ(parent->children().size(), (size_t)0);
> 
> We use C++ style casts, not C style.  That means this should be static_cast<size_t>(0)
> 
> > Source/WebKit/chromium/tests/LayerChromiumTest.cpp:193
> > +    EXPECT_EQ(parent->children().size(), (size_t)1);
> 
> should be static_cast<>. there are many more instances of this in the rest of the code, so I didn't mark them all.

Or just 0u and 1u, etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.