[Webkit-unassigned] [Bug 26382] [ES5] Implement Function.prototype.bind

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26382


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108382|review?                     |review+
               Flag|                            |




--- Comment #32 from Sam Weinig <sam at webkit.org>  2011-09-22 12:33:50 PST ---
(From update of attachment 108382)
View in context: https://bugs.webkit.org/attachment.cgi?id=108382&action=review

> Source/JavaScriptCore/runtime/JSBoundFunction.cpp:92
> +    // FIXME: our instanceof implementation will have already (incorrectly) performed
> +    // a [[Get]] of .prototype from the bound function object, which is incorrect!
> +    proto = m_targetFunction->get(exec, exec->propertyNames().prototype);

You should add a test showing this is incorrect.

> Source/JavaScriptCore/runtime/JSBoundFunction.h:66
> +    WriteBarrier<JSObject> m_targetFunction;
> +    WriteBarrier<Unknown> m_boundThis;
> +    WriteBarrier<Unknown> m_boundArgs;

How are these marked?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.