[Webkit-unassigned] [Bug 68142] AccessibilityRenderObject::previousSibling is not consistent with nextSibling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68142





--- Comment #3 from chris fleizach <cfleizach at apple.com>  2011-09-22 10:53:27 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > do you think these errors where here before your changes and you just exposed them?
> > 
> > agreed severity is low, but it's odd they don't match up
> 
> Yes, I confirmed that this assertion would have failed before any of my recent patches. It's possible that these patches made things worse - i.e. it's possible that my patch to previousSibling wasn't correct - but it wasn't 100% correct before.
> 
> It actually makes me wonder whether it's worth having a previousSibling method at all. What if instead of having public nextSibling and previousSibling methods, we just compute and store the children of each AccessibilityRenderObject in addChildren?
> 

This seems reasonable enough, it certainly buggier to have two methods (next/previous) trying to deal with continuations.

> The exception seems to be in GTK, where we need to expose a previousSibling method - but maybe it'd be okay to just replace that one with a slightly more cumbersome implementation (jump to parent, iterate over children to find the one prior to this node).
>

It sounds more accurate to check the parent's cached children for this case for sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.