[Webkit-unassigned] [Bug 68582] DFG JIT does not support to_primitive or strcat

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68582


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108297|review?                     |review+
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2011-09-22 10:36:14 PST ---
(From update of attachment 108297)
View in context: https://bugs.webkit.org/attachment.cgi?id=108297&action=review

> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:166
> +        // This is only here so that TrustedImmPtr(0) does not confuse the C++
> +        // overload handling rules.

I am a little confused by this. Why is it important to be able to compile conversion from the constant 0 and not the constant 1?

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1552
> +        // FIXME: add string speculation here.

Should capitalize the "a" in "Add".

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1611
> +        for (int operandIdx = 0; operandIdx < (int)node.numChildren(); ++operandIdx) {

Could we use size_t for this type instead of int, or is there a good reason to use int and cast numChildren? Is it just that we don’t want to use a 64-bit index?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.