[Webkit-unassigned] [Bug 68615] [Gtk] Title attribute is not respected on option elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68615


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108326|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2011-09-22 09:19:59 PST ---
(From update of attachment 108326)
View in context: https://bugs.webkit.org/attachment.cgi?id=108326&action=review

Looks good to me, but I have a few ChangeLog nits below.

> Source/WebCore/ChangeLog:3
> +        [Gtk] Respect Title attribute on Option elements.

This line should be the bug title: [Gtk] Title attribute is not respected on option elements

> Source/WebCore/ChangeLog:8
> +        Set Tooltip on menuitem widget created from GTKAction.

Watch you capilization here. Probably better to say something like: Set tooltip on PopupMenuGtk items created from GtkActions.

> Source/WebCore/ChangeLog:13
> +        * platform/gtk/GtkPopupMenu.cpp:
> +        (WebCore::GtkPopupMenu::appendItem):
> +        * platform/gtk/PopupMenuGtk.cpp:
> +        (WebCore::PopupMenuGtk::createGtkActionForMenuItem):

Please fill these out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.