[Webkit-unassigned] [Bug 67700] REGRESSION(65665): Pattern size being clamped to SVG size can prevent transformed elements from being fully covered by userSpaceOnUse patterns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67700





--- Comment #20 from Dirk Schulze <krit at webkit.org>  2011-09-22 01:27:35 PST ---
(From update of attachment 108193)
View in context: https://bugs.webkit.org/attachment.cgi?id=108193&action=review

Any need to change the tests to use just userSpaceOnUse? Don't we want to test both, userSpaceOnUse and objectBoundingBox?

> Source/WebCore/rendering/svg/SVGImageBufferTools.cpp:129
> +FloatRect SVGImageBufferTools::clampedAbsoluteTargetRect(const FloatRect& absoluteTargetRect)
>  {
> -    ASSERT(renderer);
> -
> -    const RenderSVGRoot* svgRoot = SVGRenderSupport::findTreeRootObject(renderer);
>      FloatRect clampedAbsoluteTargetRect = absoluteTargetRect;
> -    clampedAbsoluteTargetRect.intersect(svgRoot->frameRect());
> +    
> +    if (clampedAbsoluteTargetRect.width() > kMaxImageBufferSize)
> +        clampedAbsoluteTargetRect.setWidth(kMaxImageBufferSize);
> +    
> +    if (clampedAbsoluteTargetRect.height() > kMaxImageBufferSize)
> +        clampedAbsoluteTargetRect.setHeight(kMaxImageBufferSize);
> +
>      return clampedAbsoluteTargetRect;
>  }

Now that this function does not need a renderer: Can you consider to make most parts of SVGImageBufferTools independent of SVG? This way we could remove the if ENABLE(SVG) switch on platform/graphics/FETile.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.