[Webkit-unassigned] [Bug 63933] HTML canvas strokes with dash and dashOffset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63933


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108167|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Dirk Schulze <krit at webkit.org>  2011-09-22 01:13:01 PST ---
(From update of attachment 108167)
View in context: https://bugs.webkit.org/attachment.cgi?id=108167&action=review

Great start!

> LayoutTests/ChangeLog:12
> +        webkitLineDash is float[] that represents a dash-pattern of stroke.
> +        (e.g. [3, 2, 1, 4] means "on 3 units, off 2 units, on 1 units and off 4 units")

Ok, you are missing a lot of different tests. First I'd like a test with numbers > max of float. I'd also like to have a test with negative values (in different orders) and of course none-weel formed arguments '[0, 0b]' '[a, b]' and so on. A lot more stress testing.

> Source/WebCore/ChangeLog:14
> +        Add webkitLineDash and webkitLineDashOffset attributes to CanvasRenderingContext2D for JSC.
> +        These attributes can be used to determine the dash-style of stroke.
> +
> +        webkitLineDash is float[] that represents a dash-pattern of stroke.
> +        (e.g. [3, 2, 1, 4] means "on 3 units, off 2 units, on 1 units and off 4 units")
> +
> +        webkitLineDashOffset is float that is offset of the dash-pattern at which stroking would start.

Hm. It is not specified yet (as far as I know). So you have to explain why you use webkitLineDashOffset, webkitLineDash where the values come from and how it was designed. I would be extremely helpful if you can mention the discussion on the mozilla bug report and also link to this report in the change log.

It might be a good idea to explain your plans on the webkit-dev mailing list. Especially because it is not specified yet.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.