[Webkit-unassigned] [Bug 63502] [EFL] Add EflWidgetBackingStoreCairo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 21 18:34:19 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63502





--- Comment #21 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-09-21 18:34:18 PST ---
(In reply to comment #20)
> (In reply to comment #18)
> > (In reply to comment #17)
> > > (From update of attachment 107977 [details] [details] [details])
> > > Yeah, I also think this is the way to go, so I'm r-'ing this patch.
> > > 
> > 
> > As far as I know, we should not set r+ nor r- in unofficial review.
> > 
> > " Note that you should not put r+ nor r- on patches in such unofficial reviews."
> > http://www.webkit.org/coding/commit-review-policy.html
> 
> This is not how things are working. Since official reviewers want our informal r+, letting it as "r?" will only make a lot of bugs appear as unreviewed on  "webkit-patch patches-to-review". And this is what Eric Seidel, for e.g., uses to review EFL bug requests. In fact he said me it's fine for informal-reviewers to set r- after we had some problems with him rubber-stamping bugs that were already informally r- but without removing the "r?".

If reviewers said that is ok, I'm no problem, thank you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list