[Webkit-unassigned] [Bug 68586] Add X86 GPRInfo for DFG JIT.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68586


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108252|review?                     |review+
               Flag|                            |




--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2011-09-21 16:44:37 PST ---
(From update of attachment 108252)
View in context: https://bugs.webkit.org/attachment.cgi?id=108252&action=review

r=me

> Source/JavaScriptCore/dfg/DFGGPRInfo.h:46
> +    // These registers match the old JIT.

Let's call this "baseline JIT".

> Source/JavaScriptCore/dfg/DFGGPRInfo.h:59
> +    static const GPRReg argumentGPR0 = X86Registers::ecx; // regT2
> +    static const GPRReg argumentGPR1 = X86Registers::edx; // regT1
> +    static const GPRReg returnValueGPR = X86Registers::eax; // regT0
> +    static const GPRReg returnValueGPR2 = X86Registers::edx; // regT1

This numbering convention is not consistent. Would be good to make it so in a future patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.