[Webkit-unassigned] [Bug 68235] [GTK][WK2] Initial implementation of WebInspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68235





--- Comment #18 from Gustavo Noronha (kov) <gns at gnome.org>  2011-09-21 10:19:08 PST ---
(From update of attachment 107856)
View in context: https://bugs.webkit.org/attachment.cgi?id=107856&action=review

>>> Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:90
>>> +    ASSERT(!m_inspectorWindow);
>>> +    m_inspectorWindow = gtk_window_new(GTK_WINDOW_TOPLEVEL);
>>> +
>>> +    gtk_window_set_title(GTK_WINDOW(m_inspectorWindow), "Web Inspector GTK");
>> 
>> missing l10n call wrapping the string.
> 
> Bike shed moment: Probably should just title this  "Web Inspector" Users don't really care what toolkit they're using as long as it deliver to them the kittens.

hmm; do we really want to have WebKit itself create the window? What if the user agent has specific requirements for the window, wants to add more chrome to it, wants to position it, wants it to be a popup window? I feel like this makes the API less flexible without making it much more convenient. Why not use the same approach we use in wk1?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.