[Webkit-unassigned] [Bug 68540] ParallelJobs: maximum number of threads should be determined dynamically

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68540


Balazs Kelemen <kbalazs at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |kbalazs at webkit.org
                   |kit.org                     |
 Attachment #108171|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from Balazs Kelemen <kbalazs at webkit.org>  2011-09-21 10:01:12 PST ---
Created an attachment (id=108171)
 --> (https://bugs.webkit.org/attachment.cgi?id=108171&action=review)
proposed patch

This was tested on Linux and Mac, and the Windows implementation just need to work if MSDN doesn't lie. The other OS-s should work according to http://stackoverflow.com/questions/150355/programmatically-find-the-number-of-cores-on-a-machine but if that's not the case those can be fixed later (since those are not very intensively developed/tested platforms anyway).
This implementation determines the logical number of cores. This should to be ok, according to benchmark results. I tested it on Linux with Methanol - the SVG test set - on a 2 physical / 4 logical core machine. Using all the 4 cores was a win:
trunk: 2841 ms
Parallel Jobs (generic) enabled: 1974 ms
PJ enabled + patch: 1770 ms

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.