[Webkit-unassigned] [Bug 67990] [GTK] Use WebKitWebContext in WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67990


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-09-21 09:01:36 PST ---
(In reply to comment #5)

> > Might as well do:
> > webkitWebViewBaseCreateWebPage(WEBKIT_WEB_VIEW_BASE(webView), 
> >                                webkitWebContextGetContext(WEBKIT_WEB_VIEW(webView->priv->context)), 0);
> 
> I'm not sure I understand what you mean here, you are using a WebView cast for a WebContext.

Sorry. I mean this:

webkitWebViewBaseCreateWebPage(WEBKIT_WEB_VIEW_BASE(webView), 
> >                                webkitWebContextGetContext(WEBKIT_WEB_VIEW(webView)->priv->context), 

> > I'm loving these unit tests! The asterisks are on the wrong side here though.
> Unit tests are C files, not C++.

Sorry. I always forget about the silly difference in style for C files.

This patch looks good to me. I think it should be r+ with another reviewer looking at it and a few minor tweaks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.