[Webkit-unassigned] [Bug 68532] [WK2] Implement TextChecker for GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68532





--- Comment #5 from Adam Roben (:aroben) <aroben at apple.com>  2011-09-21 08:24:32 PST ---
(From update of attachment 108161)
View in context: https://bugs.webkit.org/attachment.cgi?id=108161&action=review

Anders and/or Sam should probably review this.

> Source/WebKit2/ChangeLog:75
> +        * Shared/API/c/WKBase.h: Add WKGrammarDetailRef & WKTextCheckerRef types.
> +        * Shared/API/c/win/WKBaseWin.h: Remove WKGrammarDetailRef & WKTextCheckerRef types.
> +        * Shared/APIObject.h:
> +        * UIProcess/API/C/WKAPICast.h: Added mapping for WKTextCheckerRef & WKGrammarDetailRef.
> +        (WebKit::toAPI):
> +        * UIProcess/API/C/WKGrammarDetail.cpp: Renamed from Source/WebKit2/UIProcess/API/C/win/WKGrammarDetail.cpp.
> +        (WKGrammarDetailGetTypeID):
> +        (WKGrammarDetailCreate):
> +        (WKGrammarDetailGetLocation):
> +        (WKGrammarDetailGetLength):
> +        (WKGrammarDetailCopyGuesses):
> +        (WKGrammarDetailCopyUserDescription):
> +        * UIProcess/API/C/WKGrammarDetail.h: Renamed from Source/WebKit2/UIProcess/API/C/win/WKGrammarDetail.h.
> +        * UIProcess/API/C/WKTextChecker.cpp: Renamed from Source/WebKit2/UIProcess/API/C/win/WKTextChecker.cpp.
> +        (WKTextCheckerSetClient):
> +        (WKTextCheckerContinuousSpellCheckingEnabledStateChanged):
> +        (WKTextCheckerGrammarCheckingEnabledStateChanged):
> +        (WKTextCheckerCheckSpelling):
> +        (WKTextCheckerChangeSpellingToWord):
> +        * UIProcess/API/C/WKTextChecker.h: Renamed from Source/WebKit2/UIProcess/API/C/win/WKTextChecker.h.
> +        * UIProcess/API/C/win/WKAPICastWin.h: Removed mapping for WKTextCheckerRef & WKGrammarDetailRef.
> +        * UIProcess/WebGrammarDetail.cpp: Renamed from Source/WebKit2/UIProcess/win/WebGrammarDetail.cpp.
> +        (WebKit::WebGrammarDetail::create):
> +        (WebKit::WebGrammarDetail::WebGrammarDetail):
> +        (WebKit::WebGrammarDetail::guesses):
> +        * UIProcess/WebGrammarDetail.h: Renamed from Source/WebKit2/UIProcess/win/WebGrammarDetail.h.
> +        (WebKit::WebGrammarDetail::location):
> +        (WebKit::WebGrammarDetail::length):
> +        (WebKit::WebGrammarDetail::userDescription):
> +        (WebKit::WebGrammarDetail::grammarDetail):
> +        (WebKit::WebGrammarDetail::type):
> +        * UIProcess/WebTextChecker.cpp: Renamed from Source/WebKit2/UIProcess/win/WebTextChecker.cpp.
> +        (WebKit::WebTextChecker::shared):
> +        (WebKit::WebTextChecker::WebTextChecker):
> +        (WebKit::WebTextChecker::setClient):
> +        (WebKit::updateStateForAllWebProcesses):
> +        (WebKit::WebTextChecker::continuousSpellCheckingEnabledStateChanged):
> +        (WebKit::WebTextChecker::grammarCheckingEnabledStateChanged):
> +        (WebKit::WebTextChecker::checkSpelling):
> +        (WebKit::WebTextChecker::changeSpellingToWord):
> +        * UIProcess/WebTextChecker.h: Renamed from Source/WebKit2/UIProcess/win/WebTextChecker.h.
> +        (WebKit::WebTextChecker::client):
> +        (WebKit::WebTextChecker::type):
> +        * UIProcess/WebTextCheckerClient.cpp: Renamed from Source/WebKit2/UIProcess/win/WebTextCheckerClient.cpp.
> +        (WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
> +        (WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
> +        (WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
> +        (WebKit::WebTextCheckerClient::grammarCheckingEnabled):
> +        (WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):
> +        (WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
> +        (WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
> +        (WebKit::WebTextCheckerClient::checkSpellingOfString):
> +        (WebKit::WebTextCheckerClient::checkGrammarOfString):
> +        (WebKit::WebTextCheckerClient::spellingUIIsShowing):
> +        (WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
> +        (WebKit::WebTextCheckerClient::updateSpellingUIWithMisspelledWord):
> +        (WebKit::WebTextCheckerClient::updateSpellingUIWithGrammarString):
> +        (WebKit::WebTextCheckerClient::guessesForWord):
> +        (WebKit::WebTextCheckerClient::learnWord):
> +        (WebKit::WebTextCheckerClient::ignoreWord):
> +        * UIProcess/WebTextCheckerClient.h: Renamed from Source/WebKit2/UIProcess/win/WebTextCheckerClient.h.
> +        * win/WebKit2.vcproj: Corrected paths for renamed files.
> +        * win/WebKit2Generated.make: Corrected paths for renamed files.

I really like the comments you added for the changes you made!

I think it is far more readable to delete the function names for files that were simply renamed. They're just adding noise, not information.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.