[Webkit-unassigned] [Bug 68510] [EFL] build scripts modifications to support unit tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68510


Raphael Kubo da Costa <kubo at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108123|review?, commit-queue-      |review-
               Flag|                            |




--- Comment #7 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-09-21 07:20:48 PST ---
(From update of attachment 108123)
View in context: https://bugs.webkit.org/attachment.cgi?id=108123&action=review

> ChangeLog:3
> +        [EFL] build scripts modifications to support unit tests.

Capital 'b' in build.

> ChangeLog:8
> +        Added conditions for building gtest library and building unit tests.

This could be moved to the * Source/CMakeLists.txt line.

> Source/CMakeLists.txt:147
> +# Add google unit tests (gtest)

I'd rather have all this in Source/WebKit/efl instead.

> Source/WebKit/efl/tests/CMakeListsEfl.txt:37
> +ADD_DEFINITIONS(-DGTEST_TEST_FRAMEWORK)

Is this needed for gtest to work?

> Source/WebKit/efl/tests/CMakeListsEfl.txt:39
> +ADD_LIBRARY(efl_test_launcher

What links against this library?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.