[Webkit-unassigned] [Bug 68509] [EFL] Implementation of Unit Tests framework for the WebKit-Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68509





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-09-21 01:47:29 PST ---
(From update of attachment 108121)
View in context: https://bugs.webkit.org/attachment.cgi?id=108121&action=review

Could you let me know how to run? and what is the result ?

> Source/WebKit/efl/tests/src/UnitTestLauncher/EFLTestView.cpp:40
> +EFLTestEcoreEvas::EFLTestEcoreEvas(const char *engine_name, int viewport_x, int viewport_y, int viewport_w, int viewport_h, const char *extra_options)

Move '*' type to data type.

> Source/WebKit/efl/tests/src/UnitTestLauncher/EFLTestView.cpp:76
> +EFLTestView::EFLTestView(Evas *evas, const char* url)

ditto.

> Source/WebKit/efl/tests/src/UnitTestLauncher/EFLTestView.cpp:98
> +EFLTestView::EFLTestView(Evas *evas, EwkViewType type, const char* url, int width, int height)

ditto.

> Source/WebKit/efl/tests/src/UnitTestLauncher/EFLTestView.h:30
> +    EFLTestEcoreEvas(const char *engine_name, int viewport_x, int viewport_y, int viewport_w, int viewport_h, const char *extra_options);

ditto.

In addition, do not use _ for parameter name. We are trying to use WebKit coding style except for public APIs

> Source/WebKit/efl/tests/src/UnitTestLauncher/EFLTestView.h:37
> +    Ecore_Evas *m_ecore_evas;

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.