[Webkit-unassigned] [Bug 68329] DFG should support continuous optimization

Wed Sep 21 00:16:17 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68329

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108106|0                           |1
        is obsolete|                            |
 Attachment #108112|                            |review?
               Flag|                            |

--- Comment #21 from Filip Pizlo <fpizlo at apple.com>  2011-09-21 00:16:17 PST ---
Created an attachment (id=108112)
 --> (https://bugs.webkit.org/attachment.cgi?id=108112&action=review)
the patch - fix review

I addressed Geoff's review, mostly.  I believe that the GC must mark jettisoned CodeBlocks.  I changed this so that ConservativeMarker no longer marks CodeBlocks unconditionally; it will only do so if add() is passed a JettisonedCodeBlocks.  Internally this is templatized, so we could support any number of different "MarkHooks" in the ConservativeMarker.

All of the other issues are addressed.

I haven't addressed Oliver's two concerns (RefCounted on CodeBlock and logging).  I'll look at the logging tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.