[Webkit-unassigned] [Bug 68329] DFG should support continuous optimization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68329





--- Comment #17 from Oliver Hunt <oliver at apple.com>  2011-09-20 21:52:45 PST ---
(From update of attachment 108106)
View in context: https://bugs.webkit.org/attachment.cgi?id=108106&action=review

Alas i won't finish reviewing this tonight -- i'm a little tired to follow the logic for keeping the jettisoned code blocks live for the right amount of time :-(

It may be worth making code block refcounted though if you think that would simplify things

> Source/JavaScriptCore/heap/JettisonedCodeBlocks.h:73
> +    // It would be great to use an OwnPtr<CodeBlock> here but that would
> +    // almost certainly not work.
> +    HashMap<CodeBlock*, bool> m_map;

Why can't we make CodeBlock RefCounted?  Then just use RefPtr<CodeBlock> -- a single word for the ref count vs. the hulking mass of code block doesn't seem too expensive

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.