[Webkit-unassigned] [Bug 68460] Add WebCore platform interfaces needed by updated MediaStream and PeerConnection design

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68460





--- Comment #3 from Tommy Widenflycht <tommyw at google.com>  2011-09-20 15:45:08 PST ---
(From update of attachment 108042)
View in context: https://bugs.webkit.org/attachment.cgi?id=108042&action=review

> Source/WebCore/platform/mediastream/PeerHandler.h:46
> +struct PeerHandlerConfiguration : public RefCounted<PeerHandlerConfiguration> {

Shouldn't this class be called PeerConnectionConfiguration?

>> Source/WebCore/platform/mediastream/PeerHandler.h:51
>> +        TypeTURN
> 
> I'm not quite clear which concepts are going to be in WebCore and which concepts are only in the underlying library.  I was hoping that STUN would be a library-internal concept.  Is there some reason WebCore needs to be aware of STUN?

I agree with you here, but "unfortunately" the spec specifies exactly how the configuration string should look like. The alternative, which I prefer, is to just pass the string to the platform specific code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.