[Webkit-unassigned] [Bug 64546] Redrawing dirty parts of a large table is very slow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 20 11:26:58 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64546


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107534|review?                     |review-
               Flag|                            |




--- Comment #27 from Dave Hyatt <hyatt at apple.com>  2011-09-20 11:26:58 PST ---
(From update of attachment 107534)
table->needsLayout() is too broad. The table may only need "simplified" layout (e.g., only a positioned child moved for example, in which case it won't ever get to the code you added in layout() that invalidates collapsed borders.

You need the check to be !table->selfNeedsLayout() && !table->normalChildNeedsLayout() rather than simply !table->needsLayout().

You might want to add a test case for this situation just to cover it. Make a table with a positioned block child. Do something to cause that positioned child to need a layout and then change a cell's border style (such that it would only need a repaint).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list