[Webkit-unassigned] [Bug 68430] DFG JIT performs too many negative zero checks, and too many overflow checks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68430


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107980|review?                     |review+
               Flag|                            |




--- Comment #5 from Oliver Hunt <oliver at apple.com>  2011-09-20 08:48:37 PST ---
(From update of attachment 107980)
View in context: https://bugs.webkit.org/attachment.cgi?id=107980&action=review

r=me, but remove the silly whitespace change :D

> Source/JavaScriptCore/dfg/DFGNode.h:201
> -#define NodeIdMask           0xFFF
> -#define NodeResultMask      0xF000
> -#define NodeMustGenerate   0x10000 // set on nodes that have side effects, and may not trivially be removed by DCE.
> -#define NodeIsConstant     0x20000
> -#define NodeIsJump         0x40000
> -#define NodeIsBranch       0x80000
> -#define NodeIsTerminal    0x100000
> -#define NodeHasVarArgs    0x200000
> -#define NodeClobbersWorld 0x400000
> -#define NodeMightClobber  0x800000
> +#define NodeIdMask            0xFFF
> +#define NodeResultMask       0xF000
> +#define NodeMustGenerate    0x10000 // set on nodes that have side effects, and may not trivially be removed by DCE.
> +#define NodeIsConstant      0x20000
> +#define NodeIsJump          0x40000
> +#define NodeIsBranch        0x80000
> +#define NodeIsTerminal     0x100000
> +#define NodeHasVarArgs     0x200000
> +#define NodeClobbersWorld  0x400000
> +#define NodeMightClobber   0x800000

Die whitespace die!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.