[Webkit-unassigned] [Bug 67192] API to set initial focus in gtk webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67192





--- Comment #30 from Mario Sanchez Prada <msanchez at igalia.com>  2011-09-20 08:08:44 PST ---
Hi,

Overall, the patch looks good to me, just some minor nitpicking:

(In reply to comment #29)
> Are you imagining it being an enum like FORWARD, REVERSE, NONE?

I agree with Martin, I'd rather have a enum type instead of a bool for that parameter, since it's more clear and less error prone, IMHO. See this post from  Havoc Pennington on the topic for a further explanation why I agree with this: 

http://blog.ometer.com/2011/01/20/boolean-parameters-are-wrong


With regard to this piece of code:

 [...]
 + static void test_webkit_web_view_set_initial_focus()
 + {
 +    WebKitDOMDocument* document;
 +    WebKitDOMElement* element;
 [...]

You should be declaring those parameters later in the code, as soon as you need it, instead of doing it at that early point, which is the normal thing in WK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.