[Webkit-unassigned] [Bug 67931] [GTK] Add WebKitWebContext to GTK API

Tue Sep 20 06:52:53 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=67931

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107991|review?                     |review-
               Flag|                            |

--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-09-20 06:52:53 PST ---
(From update of attachment 107991)
View in context: https://bugs.webkit.org/attachment.cgi?id=107991&action=review

Looks good to me. There's one small thing below and we just need another reviwer to review the API.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:58
> +    WebKitWebContext* webContext = WEBKIT_WEB_CONTEXT(g_object_new(WEBKIT_TYPE_WEB_CONTEXT, 0));

Sentinals have to be NULL,  because 0 is a different size than NULL on 64-bit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.