[Webkit-unassigned] [Bug 68280] [Qt] QDeskWebView missing loadProgress tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68280


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kling at webkit.org




--- Comment #13 from Andreas Kling <kling at webkit.org>  2011-09-20 05:42:12 PST ---
(In reply to comment #12)
> (From update of attachment 107894 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107894&action=review
> 
> >> Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:28
> >> +            compare(true, webView.loadProgress > -1 && webView.loadProgress < 101)
> > 
> > OMG This is just wrong. I said it may be that by the time you finish spyProgress.wait() the progress is already 100. Can't you just do compare(loadProgress != 0)?
> 
> Or is it possible that you get a first call with 0 as a value?

I rs+ the patch assuming that it works as-is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.