[Webkit-unassigned] [Bug 68280] [Qt] QDeskWebView missing loadProgress tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 20 05:37:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68280





--- Comment #11 from Alexis Menard <alexis.menard at openbossa.org>  2011-09-20 05:37:36 PST ---
(From update of attachment 107894)
View in context: https://bugs.webkit.org/attachment.cgi?id=107894&action=review

Informal Review : r-

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:28
> +            compare(true, webView.loadProgress > -1 && webView.loadProgress < 101)

OMG This is just wrong. I said it may be that by the time you finish spyProgress.wait() the progress is already 100. Can't you just do compare(loadProgress != 0)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list