[Webkit-unassigned] [Bug 63502] [EFL] Add EflWidgetBackingStoreCairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63502





--- Comment #12 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-09-20 01:13:13 PST ---
(From update of attachment 98845)
View in context: https://bugs.webkit.org/attachment.cgi?id=98845&action=review

> Source/WebCore/platform/efl/EflWidgetBackingStoreCairo.cpp:42
> +private:

When you make a private class it is common to have everything just public as it is protected anyway.

> Source/WebCore/platform/efl/EflWidgetBackingStoreCairo.cpp:49
> +        int w = size.width();
> +        int h = size.height();

We normally write things out, ie. width, height and not w, h

> Source/WebCore/platform/efl/EflWidgetBackingStoreCairo.cpp:81
> +void WidgetBackingStore::scroll(const IntRect& scrollRect, const IntSize& scrollOffset)

Maybe const IntRect& areaToScroll, const IntSize& delta) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.