[Webkit-unassigned] [Bug 63502] [EFL] Add EflWidgetBackingStoreCairo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 17:53:28 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63502





--- Comment #10 from EunMi Lee <eunmi15.lee at samsung.com>  2011-09-19 17:53:27 PST ---
(In reply to comment #4)
> > Source/WebCore/platform/efl/EflWidgetBackingStoreCairo.cpp:48
> > +        int w = size.width();
> 
> These two variables could be const.
> 
> > Source/WebCore/platform/efl/EflWidgetBackingStoreCairo.cpp:51
> > +        /* get cairo_surface from widget */
> 
> Is this comment really needed? If so, could you change it to a C++ comment? Remember you need to start with a capital letter and end with a period.
> 
> > Source/WebCore/platform/efl/EflWidgetBackingStoreCairo.cpp:57
> > +        /* create scroll surface */
> 
> Ditto.

Thanks for your comments :)
int w = size.width() is removed because it is not used anymore,
but I will be careful to use "const" for IntSize.
And I modified all comments to right style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list