[Webkit-unassigned] [Bug 68098] ValueAuto and ValueMediumDPI are the same for all platforms.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 14:53:32 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68098





--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-09-19 14:53:32 PST ---
(From update of attachment 107846)
View in context: https://bugs.webkit.org/attachment.cgi?id=107846&action=review

> Source/WebCore/ChangeLog:6
> +        320px is the layout widht which most mobile sites use as a

*width

> Source/WebCore/ChangeLog:13
> +        mobile web pages.  Allowing a platform specific default
> +        value to be set for ValueAuto of targetDensityDPI helps deal
> +        with this case.

Would be great if you made it clear how it helps. Maybe adding some comments to computeViewportAttributes in the header file. This is done elsewhere in WebKit

> Source/WebCore/ChangeLog:17
> +        No new tests needed, since it causes no behavioral change.

It would be good for tests emulating a screen less than 2 inches so we can all get the same behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list