[Webkit-unassigned] [Bug 68333] [meta] TextIterator refactoring

Mon Sep 19 10:59:27 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68333

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-19 10:59:27 PST ---
(In reply to comment #5)
> Thanks. Could you please also give some insight into the first two questions?

Sure.

> > What specifically is the [readability] problem with current code that you intend to solve? Can you describe a general direction for the changes?

I think one of the issues is that TextIterator has a lot of member variables and so many different behaviors, so I'm hoping that we can simplify some of that.

Also functions like TextIterator::advance, TextIterator::handleTextNode, TextIterator::handleTextBox should be broken down into smaller pieces with descriptive function names.  Maybe bundling some member functions into a struct/class with a bunch of helper functions (like what we did with line layout code) might help.

Finally, we should really consider sharing code between VisiblePosition, visible_units, TextIterator, etc... I think one of the issues we have now is that people working on rendering code don't necessary update all those files when they add new feature (first-letter is a good example) and some class/function gets out-of-date.  Sharing code between those classes and centralizing it in one place will probably mitigate this issue to some extent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.