[Webkit-unassigned] [Bug 58608] Groove/inset/outset borders show solid if the color is black

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58608


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107810|review?                     |review-
               Flag|                            |




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-09-19 10:55:24 PST ---
(From update of attachment 107810)
View in context: https://bugs.webkit.org/attachment.cgi?id=107810&action=review

The patch looks OK but you need to include pixel results.

> LayoutTests/fast/borders/border-Outset.html:9
> +	<style type="text/css">
> +		div {
> +			width: 200px;
> +			height: 200px;
> +			border: 20px outset #000;
> +			background-color: #0f0;
> +		}

Weird indentation here. Does it contain tabs? Please use 'black', 'green' rather than hex values.

> LayoutTests/fast/borders/border-Outset.html:14
> +		 

No need for that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.