[Webkit-unassigned] [Bug 68280] [Qt] QDeskWebView missing loadProgress tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68280


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107853|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Andreas Kling <kling at webkit.org>  2011-09-19 08:09:49 PST ---
(From update of attachment 107853)
View in context: https://bugs.webkit.org/attachment.cgi?id=107853&action=review

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:24
> +        function test_loadProgress() {
> +            compare(spy.count, 0)
> +            var testUrl = Qt.resolvedUrl("../common/test1.html")
> +            webView.load(testUrl)
> +            compare(webView.loadProgress, 0)
> +            spy.wait()
> +            compare(webView.loadProgress, 100)
> +        }

A couple of things:

- The 'testUrl' variable is not necessary, just webView.load(Qt.resolvedUrl(...))
- We should check the value of loadProgress before calling load() as well.
- This test only exercises the READ function of the loadProgress property. Why not also test that we get notified when it changes?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.