[Webkit-unassigned] [Bug 68235] [GTK][WK2] Initial implementation of WebInspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68235





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-19 04:45:22 PST ---
(In reply to comment #11)

> > > Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:79
> > > +    m_inspectorView = GTK_WIDGET(webkitWebViewBaseCreate(page()->process()->context(), inspectorPageGroup()));
> > 
> > You can use the C API here instead of the private view base API, m_inspectorView = GTK_WIDGET(WKViewCreate(toAPI(page()->process()->context()), toAPI(inspectorPageGroup()));
> Using C API will cause unnecessary back & forth between the exposed opaque structure and actual implementation structure. Current implementation is rather simple. If the concern is about using WebKitWebViewBasePrivate.h, we should move some basic WebView related functions like creation, getting PageRef of a view etc to WebKitWebViewBase.h from WebKitWebViewBasePrivate.h.


No, they are private on purpose. In most of the cases toAPI/toImpl are just casts.

> > 
> > > Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:80
> > > +    gtk_widget_set_size_request(m_inspectorView, initialWindowWidth, initialWindowHeight);
> > 
> > Do you need to enforce the view size to the initial window size?
> All ports have actually defined that as starting size, so I followed the tradition. :)

That's not the starting size, but the minimum size of the widget, which means you won't be able to make the window smaller.

> > > Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:129
> > > +    GtkWidget* inspectorWindow = m_page->viewWidget();
> > > +    return static_cast<unsigned>(gtk_widget_get_allocated_height(inspectorWindow));
> > 
> > Why do you need to get the view from the page? you have m_inspectorWindow
> Name was misleading and it should have been inspectedView. Corrected that now.

Why not use m_inspectorView then?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.