[Webkit-unassigned] [Bug 68156] HTML5 <time> initial implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68156


Vineet N Chaudhary <rgf748 at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107484|0                           |1
        is obsolete|                            |
 Attachment #107832|                            |review?
               Flag|                            |




--- Comment #7 from Vineet N Chaudhary <rgf748 at motorola.com>  2011-09-19 04:12:15 PST ---
Created an attachment (id=107832)
 --> (https://bugs.webkit.org/attachment.cgi?id=107832&action=review)
time_element_initial_patch_01

Thanks Kent Tamura for the review comments,
Please find the updated patch.

> + * Copyright (C) 2010 Apple Inc. All rights reserved.
> Why does this have Apple copyright?
Copyrights updated

> Source/WebCore/html/HTMLTimeElement.cpp:86
> +    if (m_dateComponents.type())
> Should compare with DateComponents::Invalid.
Done.

> Source/WebCore/html/HTMLTimeElement.cpp:88
> +    return 0;
> You must not return 0. The specification says we must return null Date in this case.
Corrected.

Also checking if datetime attribute is not present, then the element's 
textContent must be considered if valid.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.