[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505





--- Comment #46 from Mariusz Grzegorczyk <mariusz.g at samsung.com>  2011-09-19 03:47:35 PST ---
(From update of attachment 107665)
View in context: https://bugs.webkit.org/attachment.cgi?id=107665&action=review

>> Source/WebCore/CMakeListsEfl.txt:169
>> +    platform/network/soup/ProxyServerSoup.cpp
> 
> Is this file and the curl equivalent related to this change? I don't see proxy code being used in this patch.

When ENABLE_NETSCAPE_PLUGIN_API is on in PluginView.cpp in function PluginView::getValueForURL(), proxyServersForURL() is called. By default webkit is build with macro off and causes build break for efl port.

>> Source/WebCore/plugins/efl/PluginPackageEfl.cpp:129
>> +    m_isLoaded = true;
> 
> Is m_isLoaded really supposed to stay true if the dlsym() calls below fail?

If one of the dlsym() calls below fail program goes to abort label, which calls unloadWithoutShutdown() which sets m_isLoaded to false.

>> Source/WebCore/plugins/efl/PluginViewEfl.cpp:52
>> +#if ENABLE(NETSCAPE_PLUGIN_API)
> 
> This file is built only if NETSCAPE_PLUGIN_API is enabled, so are these checks needed?

Yes, it can be ommited

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.