[Webkit-unassigned] [Bug 35299] [Gtk] mousemove event always has metaKey == true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35299





--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-09-19 00:38:23 PST ---
(From update of attachment 105450)
View in context: https://bugs.webkit.org/attachment.cgi?id=105450&action=review

>>> Source/WebCore/ChangeLog:12
>>> +        test which shows the status of special keys for different mouse events.
>> 
>> As long as you are updating EventSender, it makes sense to make an automated test.
> 
> The metaKey attribute in EventSender was not in sync with the mouse and keyboard events from WebCore. I have added a different bug for this <https://bugs.webkit.org/show_bug.cgi?id=68324>.
> 
> Also, none of the ports uses modifier keys for mouse move in EventSender, hence a manual test case is added to test modifier keys for mouse move event.

I think it makes sense to add this to the EventSender and make the test GTK+ only for now. Manual tests don't protect us from regressions.

I'm not sure why you use a separate bug to fix EventSender, since this patch changes it below. I think it's better as one patch, since you can make the fix and test it all at once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.