[Webkit-unassigned] [Bug 68328] New: The generator and intrinsic fields in HashTableValue/HashEntry and associated structures and methods are redundant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68328

           Summary: The generator and intrinsic fields in
                    HashTableValue/HashEntry and associated structures and
                    methods are redundant
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fpizlo at apple.com


The old JIT optimizes intrinsics with ThunkGenerators, which are functions that when called generate JIT code that implements the intrinsic.  The DFG JIT optimizes intrinsics by weaving them through the optimizing compiler, and only exposes an enum (DFG::Intrinsic) for declaring whether or not an ExecutableBase is intrinsic, and if so, which intrinsic it is.

These two mechanism require some redundancy in runtime/Lookup.h, and various scripts for creating JS bindings.

A good solution would be to have one enum (say, in jit/JITIntrinsic.h).  The DFG would simply switch to using this intrinsic, while the old JIT would abandon passing function pointers and simply select the thunk generator by switching on the intrinsic enum.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.