[Webkit-unassigned] [Bug 68318] DFG JIT should inline Math.min, Math.max, and Math.sqrt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 18 09:07:47 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68318


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107780|review?                     |review+
               Flag|                            |




--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2011-09-18 09:07:47 PST ---
(From update of attachment 107780)
This looks really great.  It's a shame that the intrinsics are in addition to the "thunk generators".  The old thunks are really for intrinsics.  It would probably be cleaner to remove the ThunkGenerators from the lookup table, and just have an enum value.  When native function objects are constructed the thunk creation could just switch on the intrinsic enum value to select a generator, where one exists (and maybe over time these may be deprecated, as hot cases are inlined in the DFG JIT).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list