[Webkit-unassigned] [Bug 68316] DFG JIT does not have full block-local CSE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68316


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107773|0                           |1
        is obsolete|                            |




--- Comment #2 from Filip Pizlo <fpizlo at apple.com>  2011-09-17 14:25:29 PST ---
Created an attachment (id=107774)
 --> (https://bugs.webkit.org/attachment.cgi?id=107774&action=review)
work in progress - fixed clobber detection

This fixes a bug where nodes that might clobber the world depending on what the predictions are are not caught as having clobbered the world.  That would have potentially caused a heap access to miss a mutation performed by a valueOf method.  This does not affect performance, we still have a win.



Benchmark report for Kraken.

VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc
"PhantomCSE" at /Volumes/Data/pizlo/OpenSource/WebKitBuild/Release/jsc

Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Used 1 benchmark iteration per VM
invocation for warm-up. Used the jsc-specific preciseTime() function to get microsecond-level timing.
Reporting benchmark execution times with 95% confidence intervals in milliseconds.

                                         TipOfTree               PhantomCSE                                   

ai-astar                             633.3743+-5.5077        628.2505+-3.3314       
audio-beat-detection                 467.7312+-1.1106        465.8301+-2.4056       
audio-dft                            425.0346+-3.3409        421.6433+-3.9040       
audio-fft                            364.9765+-1.0920        363.3348+-0.7880       
audio-oscillator                     312.2311+-1.3474    ?   334.1131+-24.5161      ? might be 1.0701x slower
imaging-darkroom                     421.8919+-7.9838        412.6673+-3.6377         might be 1.0224x faster
imaging-desaturate                   207.5554+-0.8215    !   222.0429+-0.8075       ! definitely 1.0698x slower
imaging-gaussian-blur               1080.7974+-3.1483    ^   590.5500+-1.2227       ^ definitely 1.8302x faster
json-parse-financial                  49.4475+-0.2421    ?    49.8471+-0.5680       ?
json-stringify-tinderbox              67.7704+-0.3214         67.3444+-0.3539       
stanford-crypto-aes                  145.3547+-1.7446        144.5298+-1.4606       
stanford-crypto-ccm                  113.2217+-1.2073        111.4091+-1.2598         might be 1.0163x faster
stanford-crypto-pbkdf2               395.2784+-1.8910        393.7265+-1.4519       
stanford-crypto-sha256-iterative     149.5971+-0.5527    ^   148.2928+-0.5524       ^ definitely 1.0088x faster

<arithmetic>                         345.3045+-1.0924    ^   310.9701+-1.5270       ^ definitely 1.1104x faster
<geometric>                          253.0919+-0.7436    ^   243.2712+-1.0140       ^ definitely 1.0404x faster
<harmonic>                           174.9138+-0.5020    ^   173.6795+-0.4600       ^ definitely 1.0071x faster

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.