[Webkit-unassigned] [Bug 65564] Support for multiple <link rel="icon"> favicon elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65564





--- Comment #30 from Rachel Blum <groby at chromium.org>  2011-09-16 15:45:12 PST ---
(In reply to comment #28)

Fixed review issues, except

> why do you need to restrict calls to didChangeIcons?  also, why is this variable
> named favIconURL?  couldn't iconType indicate a different type of icon?

It's named favIconURL since it only notifies if the FavIcon of the particular icon type (FavIcon, Touch, PrecomputedTouch) has changed. Document _used_ to keep only one icon of each type and notified when that changed - this patch stores all icons, but still only notifies if the one that will be selected as the FavIcon by the browser changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.