[Webkit-unassigned] [Bug 68079] Set but unused variables cleanup in v8 bindings (gcc 4.6)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68079





--- Comment #8 from Adam Barth <abarth at webkit.org>  2011-09-16 12:08:35 PST ---
(From update of attachment 107626)
View in context: https://bugs.webkit.org/attachment.cgi?id=107626&action=review

> Source/WebCore/bindings/v8/WorkerScriptDebugServer.cpp:-93
>      WorkerContextExecutionProxy* proxy = workerContext->script()->proxy();
>      if (!proxy)
>          return;
> -    v8::Handle<v8::Context> context = proxy->context();

Looks like proxy is almost entirely unused now.  Maybe add a comment asking whether we should remove it?

> Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:112
> -        imp->setLength(value->Uint32Value(), ec);
> +        imp->setLength(newLength, ec);

Can we write a test for this change?  Maybe passing a length greater than UINT_MAX?

> Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp:140
> -        result = webSocket->send(toWebCoreString(message), ec);
> +        result = webSocket->send(toWebCoreString(stringMessage), ec);

This should also be testable by checking whether the toString method is called on message twice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.