[Webkit-unassigned] [Bug 67469] [WinCairo] IconDatabase::defaultIcon always fails for non-CAN_THEME_URL_ICON builds.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 16 11:58:05 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67469


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107412|review+                     |review-
               Flag|                            |




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org>  2011-09-16 11:58:06 PST ---
(From update of attachment 107412)
Overall, the change looks good.  However, it is missing a ChangeLog entry that explains the change, who made the change, and provides a link to the bugzilla entry.

Please revise the patch to include the ChangeLog (see the http://www.webkit.org/coding/contributing.html page for details).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list