[Webkit-unassigned] [Bug 67418] [chromium] Fix CCLayerTreeHostTest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67418


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107664|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #16 from James Robinson <jamesr at chromium.org>  2011-09-16 11:37:56 PST ---
(From update of attachment 107664)
View in context: https://bugs.webkit.org/attachment.cgi?id=107664&action=review

Good start.  I have some nits, but I can fix those on landing.

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:220
> +    void doEndTest()

This function seems unreachable

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:263
> +            printf("Test timed out");
> +            FAIL() << "Test timed out";

Very weird to printf() and FAIL().  The latter should produce valid output, no?

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:279
> +    Mutex m_tracesLock;
> +    Vector<std::string> m_traces;

We don't use std::string in WebKit code - we use WTF::String.  These seem completely unused, however.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.